Skip to content

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Apr 24, 2024

  • ideas taken from snowflake-sqlalchemy

 * ideas taken from snowflake-sqlalchemy
@rad-pat
Copy link
Contributor Author

rad-pat commented Apr 24, 2024

Having created this from the snowflake version, I find that it doesn't actually work with our requirements. I'm going to have to rework it a little. It needs to be able accept a select statement as the source to work for our use-case

@BohuTANG BohuTANG requested a review from hantmac April 25, 2024 00:22
@rad-pat
Copy link
Contributor Author

rad-pat commented Apr 25, 2024

@hantmac, I have resolved for our use-case. This is good for review when you're ready.

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM!

@hantmac hantmac merged commit 0c8d54e into databendlabs:main Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants