Skip to content

Remove the superset engine and entrypoint #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2024
Merged

Remove the superset engine and entrypoint #35

merged 1 commit into from
May 6, 2024

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Apr 25, 2024

  • These are now maintained in superset

@rad-pat
Remove the superset engine and entrypoint
63660b1 
 * These are now maintained in superset
@hantmac
Copy link
Member

hantmac commented Apr 27, 2024

For some old superset version, IMHO we should keep these for longer time and then delete it.

@rad-pat
Copy link
Contributor Author

rad-pat commented Apr 27, 2024

The problem with keeping them is that they would override the more recent version in the Superset code. This doesn't happen currently because of #29 - the entrypoint is incorrect so it is not loaded

@BohuTANG BohuTANG requested a review from hantmac April 29, 2024 04:57
hantmac
hantmac approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hantmac hantmac merged commit a78be72 into databendlabs:main May 6, 2024
@rad-pat rad-pat mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hantmac hantmac hantmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rad-pat @hantmac