-
Notifications
You must be signed in to change notification settings - Fork 782
feat: Use query id as trace id #17947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xuanwo <[email protected]>
For Databend query, after implementing a compatibility feature that removes all hyphens ("-") from the received query ID, and use this new query ID and trace ID for downstream transmission. Then we can merge the following pr in clients: |
Thank you for this! I will work on this PR directly. |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
…se-query-id-as-trace-id
Signed-off-by: Xuanwo <[email protected]>
…se-query-id-as-trace-id
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Use the same ID for both the query ID and the trace ID.
The OTEL specification requires the trace ID to be 128 bits (32 hex chars). To enable us to use our query ID as the trace ID, I have changed the format of our query ID from
67e55044-10b1-426f-9247-bb680e5fe0c8
to67e5504410b1426f9247bb680e5fe0c8
.I believe this should be a non-breaking change, as it is unlikely that any system depends on the specific representation of the query ID. However, we should still review this carefully to ensure we haven't introduced any unexpected issues.
Tests
Type of change
This change is