Skip to content

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Oct 21, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Refactored verify function with generic async retry support, and add unit tests to prove it works

Changelog

  • Improvement

Related Issues

Fixes #2275

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #2381 (36d5796) into main (c42c788) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2381    +/-   ##
======================================
  Coverage     71%     71%            
======================================
  Files        633     639     +6     
  Lines      35754   36041   +287     
======================================
+ Hits       25434   25687   +253     
- Misses     10320   10354    +34     
Impacted Files Coverage Δ
...datasources/table/fuse/table_do_read_partitions.rs 87% <0%> (-5%) ⬇️
common/base/src/runtime.rs 94% <0%> (-3%) ⬇️
...uery/src/datasources/table/fuse/io/block_reader.rs 78% <0%> (-2%) ⬇️
common/management/src/namespace/namespace_mgr.rs 72% <0%> (-2%) ⬇️
query/src/clusters/cluster.rs 59% <0%> (-2%) ⬇️
metasrv/src/meta_service/meta_service_impl.rs 70% <0%> (-2%) ⬇️
metasrv/src/meta_service/network.rs 78% <0%> (-1%) ⬇️
...y/src/datasources/table/fuse/table_test_fixture.rs 95% <0%> (-1%) ⬇️
...tasources/table/fuse/util/statistic_helper_test.rs 97% <0%> (-1%) ⬇️
...src/datasources/database/system/processes_table.rs 30% <0%> (-1%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42c788...36d5796. Read the comment docs.

@BohuTANG
Copy link
Member

/lgtm

@databend-bot
Copy link
Member

Approved! Thank you for the PR @ZhiHanZ

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 9776330 into databendlabs:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] refactor: generic retry policy

5 participants