Skip to content

CI workflow doesn't test builded version #478

Closed
@bonddim

Description

@bonddim

Builded version is checked in build job only with this step:

- name: Verify installation
run: |
mkdir -p helmhome
make install HELM_HOME=helmhome
helmhome/plugins/helm-diff/bin/diff version

Installing from plugin directory in helm-install and integration-tests jobs invokes install hook, which downloads binary from latest release:

- name: helm plugin install
run: helm plugin install .

- name: helm plugin install
run: helm plugin install .

Both these jobs are for testing install-binary.sh only and doesn't relate to binary itself.

It's better to move these tests to separate workflow like in #477 and write new jobs to test builded artifact on different OS-ARCH if needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions