Skip to content

add env var HELM_DIFF_NORMALIZE_MANIFESTS=true for flag --normalize-m… #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

Anthon129
Copy link

…anifests

@Anthon129
Copy link
Author

Hi

I have a scenario using helmfile apply where the golang code behind the scenes runs helm diff upgrade followed by helm upgrade --install. I need to add the flag --normalize-manifests (to helm diff command) due to other reasons but this flag is unknown to helm upgrade (causing it to fail) and I am not able to apply separate individual flags to each of the commands. The flags applied to helm diff upgrade will be applied to helm upgrade.

Can we add an environment variable (i.e. HELM_DIFF_NORMALIZE_MANIFESTS=true) that would have the same effect as --normalize-manifests ?

Thanks

Copy link

@oik741 oik741 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @Anthon129!

@dudicoco
Copy link

Hi @databus23 and @mumoshu.

Can we please merge this?

@drcrees
Copy link

drcrees commented Sep 13, 2022

👋 Hi @databus23 and @mumoshu,

Just checking in... this would greatly help clean up diffs we are generating through Helmfile.

@frank-berlin
Copy link

+1

@mumoshu mumoshu merged commit 59f7768 into databus23:master Sep 21, 2022
@drcrees
Copy link

drcrees commented Sep 22, 2022

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants