Skip to content

feature(output): add dyff powered output #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

cwrau
Copy link
Contributor

@cwrau cwrau commented Sep 28, 2022

Adds option to use dyff as a diff renderer

@cwrau
Copy link
Contributor Author

cwrau commented Oct 11, 2022

Heyho, can I do something to get this PR merged? 😊

@databus23
Copy link
Owner

Sorry for taking so long. This looks good. Can you please rebase and run a go mod tidy? Otherwise I'm fine to merge this. Thanks!

@cwrau cwrau force-pushed the feature/dyff-output branch from fa77345 to a111780 Compare December 9, 2022 14:15
@cwrau
Copy link
Contributor Author

cwrau commented Dec 9, 2022

Sure thing 😊

@cwrau
Copy link
Contributor Author

cwrau commented Jan 19, 2023

Heyho 👋, can I do something to get this rollin'? 😊

@mumoshu mumoshu force-pushed the feature/dyff-output branch from a111780 to 9a5256b Compare April 23, 2023 01:53
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally got some time to review this and this looks AWESOME! Thanks a lot for your patience and contribution @cwrau! ☺️ Merging!

@mumoshu mumoshu merged commit 1caa24c into databus23:master Apr 23, 2023
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants