Skip to content

fix(parser): don't always skip the first YAML document #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2023
Merged

fix(parser): don't always skip the first YAML document #415

merged 1 commit into from
Apr 23, 2023

Conversation

cwrau
Copy link
Contributor

@cwrau cwrau commented Oct 14, 2022 •
edited by mumoshu
Loading

Just keep skipping empty documents

Fixes #409

@cwrau
Copy link
Contributor Author

cwrau commented Jan 19, 2023

Heyho, can I do something to get this merged? 😁

@cwrau cwrau mentioned this pull request Apr 12, 2023
Closed
mumoshu
mumoshu approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh good catch! It would still skip processing on L103 if the scanned result was empty so this isn't a breaking change. LGTM.
Thank you so much for your patience and contribution @cwrau!

@mumoshu mumoshu merged commit 8ed78bc into databus23:master Apr 23, 2023
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
@cwrau @hexcsl
fix(parser): don't always skip the first YAML document (databus23#415)
68d8451 
Just keep skipping empty documents
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
@cwrau @hexcsl
fix(parser): don't always skip the first YAML document (databus23#415)
b1c9520 
Just keep skipping empty documents
@renovate renovate bot mentioned this pull request May 20, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First existing manifest gets dropped
2 participants
@cwrau @mumoshu