Skip to content

Add post-renderer-args flag #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Add post-renderer-args flag #427

merged 1 commit into from
Apr 23, 2023

Conversation

danlenar
Copy link
Contributor

Implements #396

Add post-renderder-args flags to keep in sync with helm's post-renderer-args flag

Signed-off-by: Daniel Lenar <[email protected]>
@sherifkayad
Copy link

@databus23 any chance we can get this one merged?

@alice-sawatzky
Copy link

alice-sawatzky commented Mar 23, 2023

I'm using --post-renderer-args in my workaround implementation for this Helm bug, so now i'm considering switching to this fork of helm-diff as a temporary workaround for helm-diff's lack of support for my temporary workaround for Helm 🤪

So, 👍 to this PR as it would make the above sentence less absolutely bonkers

@sherifkayad
Copy link

Sorry for nagging again .. but it would be really great to get this one merged 😞

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delayed review and thanks a lot for your patience and contribution!

@mumoshu mumoshu merged commit 64015ca into databus23:master Apr 23, 2023
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants