Fix for #430 With Helm 3 the release names are namespace scoped, thus it should be possible to helm diff release of two release with same name in different namespaces #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thus it should be possible to helm diff release of two release with same name in different namespaces
|
I am a go language nubee. I may not have used optimal syntax. |
|
. |
mumoshu
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
@sandipchitale Thanks a lot for your awesome work! I finally got some time to review this and this looks great. Let me merge this and see how it works in the wild ❤️
hexcsl
pushed a commit
to hexcsl/helm-diff
that referenced
this pull request
Jul 3, 2023
…ped, thus it should be possible to helm diff release of two release with same name in different namespaces (databus23#431) * . * Fix databus23#430 With Helm 3 the release names are namespace scoped, thus it should be possible to helm diff release of two release with same name in different namespaces * Fix syntax errors. * Fix syntax error. * Use strings library * Use correct namespace
hexcsl
pushed a commit
to hexcsl/helm-diff
that referenced
this pull request
Jul 3, 2023
…ped, thus it should be possible to helm diff release of two release with same name in different namespaces (databus23#431) * . * Fix databus23#430 With Helm 3 the release names are namespace scoped, thus it should be possible to helm diff release of two release with same name in different namespaces * Fix syntax errors. * Fix syntax error. * Use strings library * Use correct namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support syntax:
Resolves #430