Skip to content

Add support for --insecure-skip-tls-verify #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jun 4, 2023

I believe helm-diff should eventually support all the helm-template flags including connection-related ones, so that helm-diff can be used in place where helm-template or helm-upgrade-dry-run to provide diff/dry-run functionality to existing script/program/etc.

This adds support for --insecure-skip-tls which is used to disable server verification on chart download.

I believe helm-diff should eventually support all the helm-template flags including connection-related ones, so that helm-diff can be used in place where helm-template or helm-upgrade-dry-run to provide diff/dry-run functionality to existing script/program/etc.

This adds support for --insecure-skip-tls which is used to disable server verification on chart download.
@mumoshu
Copy link
Collaborator Author

mumoshu commented Jun 4, 2023

Manually tested by locally running HELM_BIN=$(which helm) ./helm-diff upgrade --allow-unreleased --insecure-skip-tls-verify foo $CHART via debugger!

@mumoshu mumoshu merged commit 8e8f883 into master Jun 4, 2023
@mumoshu mumoshu deleted the add-insecute-skip-tls-verify branch June 4, 2023 01:26
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
I believe helm-diff should eventually support all the helm-template flags including connection-related ones, so that helm-diff can be used in place where helm-template or helm-upgrade-dry-run to provide diff/dry-run functionality to existing script/program/etc.

This adds support for --insecure-skip-tls which is used to disable server verification on chart download.
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
I believe helm-diff should eventually support all the helm-template flags including connection-related ones, so that helm-diff can be used in place where helm-template or helm-upgrade-dry-run to provide diff/dry-run functionality to existing script/program/etc.

This adds support for --insecure-skip-tls which is used to disable server verification on chart download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants