refactor(diff): extract secret handling to preHandleSecrets #787
+65
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of secrets in the
diff
package to improve code reuse and readability. The changes include introducing a helper function for decoding secrets, updating related methods to use this helper, and adding a new test case to ensure correct behavior when bothstringData
anddata
fields are present in Kubernetes secrets.Refactoring for code reuse and clarity:
preHandleSecrets
indiff/diff.go
to centralize the logic for decoding secrets and handling errors. This function is now used in bothredactSecrets
anddecodeSecrets
to avoid code duplication. [1] [2] [3]Testing improvements:
diff_test.go
to verify thatdecodeSecrets
correctly prioritizesstringData
overdata
when both fields are present in Kubernetes secrets. This ensures the expected behavior when handling secret resources.