Skip to content

chore: add gsc meta tag for verification #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

ben-brooker
Copy link
Contributor

@ben-brooker ben-brooker commented Jun 27, 2022

TICKET

Add link to verify for google-search-console

Screenshot 2022-06-27 at 17 20 17

@ben-brooker ben-brooker requested a review from ztsorojev June 27, 2022 16:21
@@ -22,6 +22,7 @@ export default function Layout({
<>
<Head>
<title>{title ? `${title} - RDocumentation` : 'RDocumentation'}</title>
<meta name="google-site-verification" content="l7VjaJvG_OgqxbCyZDDtk_ykMcPXyqwTSoWnf94hGQk" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in _document.tsx, thats the default file in Next to add those things 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason why some of these HTML tags are in here instead of all being in _document.tsx is because these are dynamic (they change based on the page) vs everything in _document.tsx is static

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to _document instead. I realised after committing that the branch was behind main so I corrected it, thats why there are other files that are changed. should be fine now

@ben-brooker ben-brooker force-pushed the bb/google-search-console branch from 9d3654b to 547aa5a Compare June 29, 2022 15:40
<MathJax>
<MathJax hideUntilTypeset="first">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why those Mathjax changes are here, maybe you rebase from the wrong branch? 🤔

Copy link
Contributor

@ztsorojev ztsorojev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@ben-brooker ben-brooker merged commit 1f40ff7 into main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants