DAS-459 send emails with AWS SES #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavji
requested review from
benshaw,
augustinas,
whiteshadow-gr,
pperzyna and
dataswifty
|
|
||
| private def content(s: String): Content = | ||
| new Content(s).withCharset(StandardCharsets.UTF_8.name()) | ||
|
|
||
| } |
There was a problem hiding this comment.
Can we add a new line, please?
whiteshadow-gr
approved these changes
Mar 18, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
benshaw
approved these changes
Mar 18, 2021
pperzyna
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC
AC Current Behaviour (optional):
Data Plugs require AWS KEYs to connect to AWS. More specifically for this card, Data Plugs use AWS SES to send emails. We use credentials instead of Roles for this.
User Story (required):
As DS Eng I would like that Data Plugs can consume AWS Roles instead of AWS Keys to send emails
Source
https://dswift.atlassian.net/browse/DAS-459
Type
Checklist