Include length in signatures (hypercore v9 compat) #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
signatures-hypercore-v9
branch
from
98863ed to
a1fe9fb
Compare
bltavares
force-pushed
the
signatures-hypercore-v9
branch
from
d210980 to
82caad6
Compare
|
TODO
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hypercore will soon release a new major version (v9) that will include a change to the signatures: They will now include the feed length in addition to the tree hash. See this issue for details.
This PR ports the change. One test with static signatures in it is not yet updated (set to ignore).
Checklist
Context
hypercore/260
Semver Changes
minor or major, not sure. likely squash with the async changes into a single new major.