remove builder pattern #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ZhouHansen, thanks for the PR. I'm cleaning up open PRs to help new contributors. This PR has a few conflicts, and according to the discussion on #72, removing the builder does not seem to be the way to go. Using builders are documented on several API Guidelines: While currently we have a few options that would make Feed trivial to build, the discussion on #109 and #113 might require more complex builders to allow multiple storage locations. I will close this PR as there are conflicts, and we could revisit topic after the storage changes to see if maintaining a builder is worth vs the complexity of initializing a new Feed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#72