Remove mypy version pin
#224
Labels
Comments
|
Raised python/mypy#11843 |
daviddrysdale
added a commit
that referenced
this issue
Dec 26, 2021
A statement like `from .local import THING` in `current.py` makes `THING` available in the current module, but this also acts as ani export (i.e. `current.THING` is defined). As of version 0.930 of mypy, the `stubtest` checker wants to see a type definition for such things, when they are ints or strings. Add the equivalent `from .local import THING` statements into the .pyi stub files, so `stubtest` can see the associated type definition. For autogenerated `*data/__init__.pyi` files, this involves a change to the metadata generation tool. Also: - Fix asyoutypeformatter.py to import `REGION_CODE_FOR_NON_GEO_ENTITY` from `phonemetadata` (the definition) rather than `phonenumberutil` (a re-export). - Rename local loop variables to start with an underscore in (autogenerator for) `*data/__init__.py` so they don't look like things that should be exported. - Drop version pin (==0.921) for mypy. Fixes #224.
daviddrysdale
added a commit
that referenced
this issue
Dec 27, 2021
A statement like `from .local import THING` in `current.py` makes `THING` available in the current module, but this also acts as an export (i.e. `current.THING` is defined). As of version 0.930 of mypy, the `stubtest` checker wants to see a type definition for such things, when they are ints or strings. Add the equivalent `from .local import THING` statements into the .pyi stub files, so `stubtest` can see the associated type definition. For autogenerated `*data/__init__.pyi` files, this involves a change to the metadata generation tool. Also: - Fix asyoutypeformatter.py to import `REGION_CODE_FOR_NON_GEO_ENTITY` from `phonemetadata` (the definition) rather than `phonenumberutil` (a re-export). - Rename local loop variables to start with an underscore in (autogenerator for) `*data/__init__.py` so they don't look like things that should be exported. - Drop version pin (==0.921) for mypy. Fixes #224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit ce13f47 pinned the version of
mypyused in CI to 0.921, because 0.930 failsrun_stubtest.py:As a guess, something in
mypythat handles local imports has changed/broken.Hopefully this will be fixed in a future version of
mypy; this issue is a reminder to check back at some point, and if the problem is fixed, to remove the version pin.The text was updated successfully, but these errors were encountered: