Skip to content

fix get_db_prep_value when value is unicode #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix get_db_prep_value when value is unicode #29

wants to merge 2 commits into from

Conversation

zebuline
Copy link

No description provided.

@luto
Copy link
Collaborator

luto commented Nov 5, 2014

This PR really boils down to this line:

- if isinstance(value, str):
+ if isinstance(value, basestring):

The hyphenate-issue was already fixed (see #36).

Could you please re-submit a PR only contaning this change, since this PR has conflicts or tell me if this issue has been resolved?

@jaredlewis
Copy link

Any timetable on getting this merged? This is a flaw and is occurring for me in python 3.4

@micahhausler
Copy link

Rather than using basestring, can this use six.string_types?

@zebuline zebuline mentioned this pull request Nov 12, 2014
Open
@zebuline
Copy link
Author

New PR here: #45

@zebuline zebuline closed this Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zebuline @luto @jaredlewis @micahhausler @hobbestigrou