Skip to content

feat: add optimized config from ddev/ddev-redis-7 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Apr 24, 2025

The Issue

We want to consolidate all configs in one place.

This PR makes ddev/ddev-redis-7 obsolete.

How This PR Solves The Issue

  • Adds ddev dotenv set .ddev/.env.redis --redis-optimized=true
  • Adds extra docker-compose configs to .ddev/docker-compose.redis_extra.yaml
  • Adds tests for --redis-optimized=true

Important

The difference is in the password: ddev/ddev-redis-7 uses the password redis and I use an empty password.

Manual Testing Instructions

Review https://github.com/ddev/ddev-redis/blob/20250424_stasadev_redis-7/README.md

ddev dotenv set .ddev/.env.redis --redis-optimized=true
ddev add-on get https://github.com/ddev/ddev-redis/tarball/20250424_stasadev_redis-7
ddev restart

# see config files from ddev/ddev-redis-7
ls -la .ddev/redis

# see changed file
cat .ddev/redis/redis.conf

# run some redis command
ddev redis-flush

# or "rm -f .ddev/.env.redis"
ddev dotenv set .ddev/.env.redis --redis-optimized=false
ddev add-on get https://github.com/ddev/ddev-redis/tarball/20250424_stasadev_redis-7
ddev restart

# see only one redis.conf
ls -la .ddev/redis

# see original file
cat .ddev/redis/redis.conf

# run some redis command
ddev redis-flush

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev changed the title feat: add configs from ddev/ddev-redis-7, enable Redis persistence by default feat: use redis:7, add configs from ddev/ddev-redis-7, enable Redis persistence Apr 24, 2025
@stasadev stasadev force-pushed the 20250424_stasadev_redis-7 branch from b3daecd to f974adf Compare April 25, 2025 13:10
@stasadev stasadev changed the title feat: use redis:7, add configs from ddev/ddev-redis-7, enable Redis persistence feat: add optimized config from ddev/ddev-redis-7 Apr 25, 2025
@stasadev stasadev force-pushed the 20250424_stasadev_redis-7 branch from f974adf to 200518d Compare April 25, 2025 13:15
@stasadev stasadev merged commit 927e85b into main Apr 25, 2025
2 checks passed
@stasadev stasadev deleted the 20250424_stasadev_redis-7 branch April 25, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants