build: allow forked PRs to build previews, fixes #79 #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add content validation checks for executable files and unsafe patterns - Integrate textlint and prettier quality checks before build - Validate blog post frontmatter structure (title, pubDate, author) - Add image size warnings for files >2MB - Fix YAML syntax issues with placeholder HTML generation - Create comprehensive setup guide with troubleshooting section - Document required Cloudflare secrets and configuration steps 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…oject - Change CF_ACCOUNT_ID and CF_PAGES_PROJECT from secrets to vars references - Update documentation to clarify secrets vs variables configuration - This resolves deployment failures due to missing secret references 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
rfay
force-pushed
the
20250919_rfay_forked_pr_preview
branch
from
14d5e3d to
a863d70
Compare
Deploying ddev-com-front-end with
|
| Latest commit: |
ddf18ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33a5d63c.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://20250919-rfay-forked-pr-prev.ddev-com-front-end.pages.dev |
- Configure workflow to use existing ddev-com-front-end Cloudflare project
- Provides consistent preview URLs with main repository
- Update documentation to reflect unified project approach
- Preview URLs will be: https://pr-{number}.ddev-com-front-end.pages.dev
- Eliminates need for separate Cloudflare project setup
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update to use TESTS_SERVICE_ACCOUNT_TOKEN (not PUSH_SERVICE_ACCOUNT_TOKEN) - Clarify CF_API_TOKEN comes from test-secrets vault - Match actual workflow configuration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Prefer steps.pages.outputs.url (branch-based) over deployment-url (commit-based)
- Add logging to show which URL type is being used
- Ensure fork PRs get stable pr-{number}.ddev-com-front-end.pages.dev URLs
- Update comment text to indicate URL type for clarity
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Fix comment detection pattern to match actual text 'Cloudflare Pages' - Add comprehensive logging to debug Cloudflare URL outputs - Improve comment format with clear PR number and instructions - Add debugging info to understand why multiple deployments occur 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix multiline template string that was breaking YAML parser - Split long logging lines to meet prettier requirements - Auto-format file with prettier to ensure consistent style - Resolve syntax error that was preventing CI from passing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add comprehensive debugging for comment detection - Improve comment search to match github-actions[bot] specifically - Check for existing URLs to track Cloudflare deployment behavior - Log all comments and their properties for troubleshooting - Prevent duplicate comment fetching by reorganizing logic 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add known issues section with URL stability problem description - Document three potential approaches to achieve stable preview URLs - Note current working status (comment updates work, URLs still change) - Preserve investigation paths for future implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
rfay
commented
Sep 19, 2025
There was a problem hiding this comment.
I'm going to go ahead and pull this. I doubt it's perfect, and it has URL stability issues which may not be solvable. But it's hard to test fully until we pull, and I think it has no risk. Will look forward to your retroactive review @stasadev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Allow forked previews
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes