Skip to content

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Sep 23, 2025

The Issue

#42 (duplicate of #44 without the exponential retry script.)

How This PR Solves The Issue

Install DDEV as a binary instead via apt.

More details in #42 (comment)

Manual Testing Instructions

Modify your workflow.yml to leverage/test changes in the PR.

      - name: Install DDEV
        uses: mxr576/github-action-setup-ddev@install-ddev-as-binary-without-retry

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@wundo
Copy link

wundo commented Sep 25, 2025

@mxr576 do you have any benchmarks of before and after your changes?

@mxr576
Copy link
Contributor Author

mxr576 commented Sep 25, 2025

After maintainers approve workflow to run on this PR, the comparison should be easy with previous action runs on this repo (from the parent issue):

I think this problem is also visible on this project.

Proof:

Run 1: Takes 47s
Run 2: Takes 1m 25s
Run 3: Takes 2m
Billing Overview

But what can be already seen on my fork is that DDEV instillation takes less than 10s after this change.

https://github.com/mxr576/github-action-setup-ddev/actions/workflows/main.yml?query=branch%3Ainstall-ddev-as-binary-without-retry

image

@mxr576
Copy link
Contributor Author

mxr576 commented Sep 25, 2025

@rfay I have removed the redundant dependabot config, could you please reapprove the workflow run? Thank you

@mxr576
Copy link
Contributor Author

mxr576 commented Sep 28, 2025

So now that the performance ( -> billing) improvements are also visible on the PR, is there anything that needs to be addressed before this can be merged?

@mxr576
Copy link
Contributor Author

mxr576 commented Sep 30, 2025

@jonaseberle @davereid could you check this PR and share if you have any concerns with the changes? Thank you

@mxr576
Copy link
Contributor Author

mxr576 commented Sep 30, 2025

Should I rebase or will you?

@rfay
Copy link
Member

rfay commented Sep 30, 2025

It has conflicts to resolve, so please resolve them @mxr576

@jonaseberle
Copy link
Member

@mxr576 please do so.

@mxr576 mxr576 force-pushed the install-ddev-as-binary-without-retry branch from 3e1b27e to 18bbe35 Compare September 30, 2025 12:22
@mxr576
Copy link
Contributor Author

mxr576 commented Sep 30, 2025

Rebased, still works on my fork: https://github.com/mxr576/github-action-setup-ddev/actions/runs/18129786023

Actions has to be triggered here as well.

jonaseberle
jonaseberle previously approved these changes Sep 30, 2025
@mxr576
Copy link
Contributor Author

mxr576 commented Sep 30, 2025

Thx for the approval! For the record, I do not have merge permission to merge this PR.

@jonaseberle jonaseberle merged commit b5d96cd into ddev:main Sep 30, 2025
4 checks passed
@jonaseberle
Copy link
Member

Thank you!

@rfay
Copy link
Member

rfay commented Sep 30, 2025

Thanks for the contributions here @mxr576 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants