-
-
Notifications
You must be signed in to change notification settings - Fork 13
Install DDEV binary manually instead via APT (no retry script) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install DDEV binary manually instead via APT (no retry script) #46
Conversation
@mxr576 do you have any benchmarks of before and after your changes? |
After maintainers approve workflow to run on this PR, the comparison should be easy with previous action runs on this repo (from the parent issue):
But what can be already seen on my fork is that DDEV instillation takes less than 10s after this change. ![]() |
@rfay I have removed the redundant dependabot config, could you please reapprove the workflow run? Thank you |
So now that the performance ( -> billing) improvements are also visible on the PR, is there anything that needs to be addressed before this can be merged? |
@jonaseberle @davereid could you check this PR and share if you have any concerns with the changes? Thank you |
Should I rebase or will you? |
It has conflicts to resolve, so please resolve them @mxr576 |
@mxr576 please do so. |
More details in ddev#42 (comment)
to prove transient failures without it.
since the project no longer nodejs based
3e1b27e
to
18bbe35
Compare
Rebased, still works on my fork: https://github.com/mxr576/github-action-setup-ddev/actions/runs/18129786023 Actions has to be triggered here as well. |
Thx for the approval! For the record, I do not have merge permission to merge this PR. |
Thank you! |
Thanks for the contributions here @mxr576 ! |
The Issue
#42 (duplicate of #44 without the exponential retry script.)
How This PR Solves The Issue
Install DDEV as a binary instead via
apt
.More details in #42 (comment)
Manual Testing Instructions
Modify your workflow.yml to leverage/test changes in the PR.
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes