Stop subtracting 14 pixels from the right side of the canvas for determi... #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmining the rectangle for graphing in. This behavior is unpredictable and makes implementing something like a range slider where pixels get mapped to time very challenging.
|
|
!
|
🐰 !! If I recall, this was a cheap way of giving the graph some padding on the right. Probably should be replaced with a more explicit padding object. ps. Hi guys! |
|
hey joel!! hey dan! happy new years... oh and ben too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ning the rectangle for graphing in. This behavior is unpredictable and makes implementing something like a range slider where pixels get mapped to time very challenging.