Skip to content

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jul 21, 2025

  • Plotly.js 3.0.x has an issue where it's bringing in some unnecessary webpack dependencies, and I think is causing issues when updating Grizzly+ with the latest web packages
  • Used the package-lock.json from before we updated to plotly.js v3.0.0 and jumped straight to v3.1.0-rc.0, which shouldn't have the issue, then updated package-lock.json again
  • This should resolve the build issues in G+ when updating packages
  • Bumped up the heap size to avoid some build issues

mofojed added 2 commits July 21, 2025 17:14
- Plotly.js 3.0.x has an issue where it's bringing in some unnecessary webpack dependencies, and I think is causing issues when updating Grizzly+ with the latest web packages
- Used the package-lock.json from before we updated to plotly.js v3.0.0 and jumped straight to v3.1.0-rc.0, which shouldn't have the issue, then updated package-lock.json again
- This should resolve the build issues in G+ when updating packages
@mofojed mofojed requested a review from jnumainville July 21, 2025 21:18
@mofojed mofojed self-assigned this Jul 21, 2025
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (8c8edd5) to head (cfd3663).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   44.67%   44.67%           
=======================================
  Files         762      762           
  Lines       42617    42617           
  Branches    10906    10906           
=======================================
  Hits        19038    19038           
  Misses      23522    23522           
  Partials       57       57           
Flag Coverage Δ
unit 44.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed marked this pull request as ready for review July 21, 2025 21:30
@mofojed mofojed merged commit adc2c0a into deephaven:main Jul 23, 2025
11 checks passed
@mofojed mofojed deleted the update-plotly-v3.1.0-rc.0 branch July 23, 2025 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants