Tweaks based on our requirements #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the ./monaco_editor/package.json "start" script
When there is a table specified in the FROM clause, only suggest unscoped columns from that table. If no table is specified, suggest all columns from all tables.
Only suggest tables and aliases that are in the FROM clause after SELECT keyword, instead of all tables
So instead of showing `catalog1.schema1.table1` all at once after FROM, we'll only show catalog1, and then after a dot, we'll suggest schema1, and only when we have `SELECT * FROM catalog1.schema1.` will be suggest table1. It's a total hack, putting it all in the `createTableCandidates` function, but it works and it's the fastest way to implement this.
packages/server/src/complete/candidates/createTableCandidates.ts
Outdated
Show resolved
Hide resolved
packages/server/src/complete/candidates/createTableCandidates.ts
Outdated
Show resolved
Hide resolved
petrfejfar
approved these changes
Mar 20, 2023
the21st
force-pushed
the
ss/improvements-2
branch
from
f599586 to
f0b5dcb
Compare
|
@petrfejfar I think I got it running by running Let me know if that worked for you |
the21st
force-pushed
the
ss/improvements-2
branch
from
f0b5dcb to
2928b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.