Skip to content

Change package/server dependancy to local sql-parser #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ondrejromancov
Copy link

All the changes I made in #7 were in packages/sql-parser. While running the publishing GitHub action we are building packages/server, but it has a dependency on the published @joe-re/sql-parser and not the one I modified. ChatGPT advised me that the packages/server dependency could be changed to the local sql-parser so I modified using "@joe-re/sql-parser": "file:../sql-parser".

If I'm proceeding correctly, what could be the next steps?

  1. This pull request
  2. Re-publish the new version of deepnote/sql-language-server with the same tag v1.7.2-deepnote. ChatGPT advised me that removing and pushing the same tag should overwrite it

@ondrejromancov ondrejromancov requested a review from the21st June 13, 2024 17:50
@ondrejromancov ondrejromancov merged commit d8759f9 into release Jun 14, 2024
1 check passed
@ondrejromancov ondrejromancov deleted the orom/change-package-server-dependancy-to-local-sql-parser branch June 14, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants