Skip to content

Feature/information center #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 14, 2019
Merged

Feature/information center #125

merged 20 commits into from
Mar 14, 2019

Conversation

winniedo
Copy link
Contributor

@winniedo winniedo commented Mar 3, 2019

This branch content implementation of the Information Center, displaying all one-time events.

@ghost ghost assigned winniedo Mar 3, 2019
@ghost ghost added the review label Mar 3, 2019
@winniedo winniedo requested a review from janniclas March 3, 2019 20:44
@janniclas
Copy link
Contributor

hey @winniedo ,
please provide a description of the features and changes contained in this pull request.
Also the automatic tests are failing, please have a look at this before I start reviewing the code.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #125 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #125   +/-   ##
======================================
  Coverage        0%     0%           
======================================
  Files           13     13           
  Lines           16     16           
  Branches         2      2           
======================================
  Misses          16     16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9174864...be812ac. Read the comment docs.

@ghost ghost assigned janniclas Mar 8, 2019
Copy link
Contributor

@janniclas janniclas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @winniedo ,
I have made some changes to the socket service so that we only receive one event for every action as intended. by doing this a bug in your code was revealed:
The notification center only updates if there have been more than 6 elements added to the table. please have a look at this

@winniedo
Copy link
Contributor Author

winniedo commented Mar 8, 2019

OK, @janniclas I will review your changes and adapt it to my code at the weekend.

@janniclas janniclas merged commit e425791 into develop Mar 14, 2019
@ghost ghost removed the review label Mar 14, 2019
@janniclas janniclas deleted the feature/informationCenter branch March 14, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants