Skip to content

Feature/delete instance feedback #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Conversation

Naveenkumar27
Copy link
Contributor

This pull request focuses on issue #116. A feedback is provided using appropriate alert message for a failed delete operation of an instance.

@ghost ghost assigned Naveenkumar27 Mar 7, 2019
@ghost ghost added the review label Mar 7, 2019
@Naveenkumar27 Naveenkumar27 requested a review from janniclas March 7, 2019 12:48
removed unnecessary logs
@ghost ghost assigned janniclas Mar 7, 2019
Copy link
Contributor

@janniclas janniclas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice pull request :)

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #126 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #126   +/-   ##
=======================================
  Coverage     4.18%   4.18%           
=======================================
  Files           12      12           
  Lines          239     239           
  Branches        12      12           
=======================================
  Hits            10      10           
  Misses         229     229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b3c95...513d6e6. Read the comment docs.

@janniclas janniclas merged commit ff58100 into develop Mar 7, 2019
@ghost ghost removed the review label Mar 7, 2019
@janniclas janniclas deleted the feature/deleteInstanceFeedback branch March 7, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants