DLPX-91653 Use default inotify.max_user_watches

[david-mendez1]

Problem

Customers still occasionally hit the inotify.max_user_watches limit even at the max setting of 32768. Use default inotify.max_user_watches now that the following Linux change has increased the max_user_watches based on the amount of addressable memory available.

inotify: Increase default inotify.max_user_watches limit to 1048576 · torvalds/linux@9289012

Solution

Remove hard coded max value for fs.inotify.max_user_watches in 50-override.conf.

Testing Done

ab-pre-push
http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/8954/

Test different instance sizes:

david.mendez@dlpxdc:~$ dc list -o size sync-vm-8a5cd044-6619-0
SIZE
T3_LARGE
delphix@ip-10-110-194-224:~$ cat /proc/sys/fs/inotify/max_user_watches 
56783

david.mendez@dlpxdc:~$ dc list -o size,source_group dm-test-aws
SIZE                 SOURCE_GROUP
DE_CERT_R5N_8XLARGE  temp-sync-AWS-image
elphix@ip-10-110-217-97:~$ cat /proc/sys/fs/inotify/max_user_watches 
1048576

[palash-gandhi]

lgtm, we may want to give the scale & perf folks a heads up to keep an eye out for unusual memory trends.