APIGW-10470 Delphix startup screen should be updated for DCT appliances #501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are updating the delphix-startup-screen to work for DCT appliances by making the following changes:
First, we are displaying the packaged-app-version (i.e DCT version) instead of appliance version when it is available.
Then, we are avoiding an exception for network intefaces without address (using python
get
instead of[]
).We are hiding the DCT appliance network interfaces (docker0 and docker bridges). This is currently done by name matching, if anyone knows of a better way to identify them that would be great.
Finally, it appears that the list of systemd services now may exceed the available vertical space. While we might want to redesign the screen, or identify which services are critical or not to be visible, I've implemented a much simpler fix by catching the exception and simply moving on (so for DCT appliances the state of the last service, in the order returned by the
systemctl show
command, is missing).Testing Done
A dcol2 standard engine
