Skip to content

APIGW-10470 Delphix startup screen should be updated for DCT appliances #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eyalkaspi-delphix
Copy link
Contributor

@eyalkaspi-delphix eyalkaspi-delphix commented Nov 5, 2024

In this PR, we are updating the delphix-startup-screen to work for DCT appliances by making the following changes:

First, we are displaying the packaged-app-version (i.e DCT version) instead of appliance version when it is available.

Then, we are avoiding an exception for network intefaces without address (using python get instead of []).

We are hiding the DCT appliance network interfaces (docker0 and docker bridges). This is currently done by name matching, if anyone knows of a better way to identify them that would be great.

Finally, it appears that the list of systemd services now may exceed the available vertical space. While we might want to redesign the screen, or identify which services are critical or not to be visible, I've implemented a much simpler fix by catching the exception and simply moving on (so for DCT appliances the state of the last service, in the order returned by the systemctl show command, is missing).

Testing Done

A dcol2 DCT appliance (note the DCT version, long list of services, and only the external IP address is visible)

image

A dcol2 standard engine
image

@eyalkaspi-delphix eyalkaspi-delphix force-pushed the dlpx/pr/eyalkaspi-delphix/b87467e3-a73f-4ce3-b59f-348b2a996dff branch from df66efb to 0835970 Compare November 5, 2024 11:41
@eyalkaspi-delphix eyalkaspi-delphix marked this pull request as ready for review November 5, 2024 11:52
Copy link

@delphixBrandonB delphixBrandonB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm using very similar logic to hide the network interfaces.

@eyalkaspi-delphix eyalkaspi-delphix merged commit 8aa7466 into develop Nov 7, 2024
15 checks passed
@eyalkaspi-delphix eyalkaspi-delphix deleted the dlpx/pr/eyalkaspi-delphix/b87467e3-a73f-4ce3-b59f-348b2a996dff branch November 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants