DLPX-94300 vmtoolsd conf file not updated due to error in ansible file #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebroy
force-pushed
the
dlpx/pr/sebroy/53eee98e-8a5d-4d34-8aa0-94c196dba226
branch
from
2f2950f to
a7ea83b
Compare
jwk404
approved these changes
May 20, 2025
tonynguien
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform name for ESX is not "vmware", but "esx". As such, ansible tasks that are conditionally applied on ESX need to have the correct platform conditional.
Testing
I applied this on dcol1 and dcol2 and restarted the delphix-platform service. Both applied the configuration successfully.
ab-pre-push: https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/github/job/delphix/job/delphix-platform/job/appliance-build-orchestrator/job/pre-push/645/