Skip to content

Missing copyright #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Missing copyright #12

merged 2 commits into from
Jun 5, 2020

Conversation

sravyamks
Copy link

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sdimitro
Copy link

sdimitro commented Jun 5, 2020

Similar feedback to previous commit :-) . Once that is done I'll go ahead and merge this.

@ahrens
Copy link

ahrens commented Jun 5, 2020

Is this something that we could request to be added upstream?

@sdimitro
Copy link

sdimitro commented Jun 5, 2020

@ahrens The upstream drgn repository doesn't generate deb packages and does not have a debian folder in the root directory. Thus this commit by itself cannot make it upstream.

Now if the question was whether we should request upstream drgn to have a debian directory for people who want to generate packages, I believe that we could do that. It would take some effort though as we can't just use that try to upstream our debian directory. The reason is that our directory's contents are pretty minimal and specific because they depend on functionality provided by linux-pkg which builds the package for us.

@sdimitro sdimitro merged commit a6a0725 into delphix:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants