Skip to content

DLPX-87710 upgrade from 6.0.16.0 to 15.0.0.0 failed because disk quota error #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

palash-gandhi
Copy link
Contributor

@palash-gandhi palash-gandhi commented Sep 5, 2023

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/f1f42a0c-5846-4956-b909-1c9c469c7096 branch from fed5c90 to 1f3d2c4 Compare September 5, 2023 20:56
@palash-gandhi palash-gandhi marked this pull request as ready for review September 5, 2023 20:59
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/f1f42a0c-5846-4956-b909-1c9c469c7096 branch 2 times, most recently from f4ee9d6 to c6e1cba Compare September 6, 2023 01:40
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/f1f42a0c-5846-4956-b909-1c9c469c7096 branch from c6e1cba to fb9e1e0 Compare September 6, 2023 21:06
@palash-gandhi palash-gandhi merged commit 5083803 into develop Sep 7, 2023
@palash-gandhi palash-gandhi deleted the dlpx/pr/palash-delphix/f1f42a0c-5846-4956-b909-1c9c469c7096 branch September 7, 2023 03:20
delphix-devops-bot pushed a commit that referenced this pull request Sep 19, 2024
BugLink: https://bugs.launchpad.net/bugs/2072617

[ Upstream commit e64746e74f717961250a155e14c156616fcd981f ]

cpumask_of_node() can be called for NUMA_NO_NODE inside do_map_benchmark()
resulting in the following sanitizer report:

UBSAN: array-index-out-of-bounds in ./arch/x86/include/asm/topology.h:72:28
index -1 is out of range for type 'cpumask [64][1]'
CPU: 1 PID: 990 Comm: dma_map_benchma Not tainted 6.9.0-rc6 #29
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996)
Call Trace:
 <TASK>
dump_stack_lvl (lib/dump_stack.c:117)
ubsan_epilogue (lib/ubsan.c:232)
__ubsan_handle_out_of_bounds (lib/ubsan.c:429)
cpumask_of_node (arch/x86/include/asm/topology.h:72) [inline]
do_map_benchmark (kernel/dma/map_benchmark.c:104)
map_benchmark_ioctl (kernel/dma/map_benchmark.c:246)
full_proxy_unlocked_ioctl (fs/debugfs/file.c:333)
__x64_sys_ioctl (fs/ioctl.c:890)
do_syscall_64 (arch/x86/entry/common.c:83)
entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130)

Use cpumask_of_node() in place when binding a kernel thread to a cpuset
of a particular node.

Note that the provided node id is checked inside map_benchmark_ioctl().
It's just a NUMA_NO_NODE case which is not handled properly later.

Found by Linux Verification Center (linuxtesting.org).

Fixes: 65789da ("dma-mapping: add benchmark support for streaming DMA APIs")
Signed-off-by: Fedor Pchelkin <[email protected]>
Acked-by: Barry Song <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Portia Stephens <[email protected]>
Signed-off-by: Stefan Bader <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants