Skip to content

Switch to Python 3 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

Switch to Python 3 #9

merged 1 commit into from
Jan 15, 2020

Conversation

gllghr
Copy link
Contributor

@gllghr gllghr commented Nov 19, 2019 •
edited
Loading

This converts all of the python 2 code to python 3.

prashks
prashks reviewed Nov 19, 2019
View reviewed changes
sebroy
sebroy reviewed Nov 19, 2019
View reviewed changes
@gllghr gllghr mentioned this pull request Nov 19, 2019
Closed
@sebroy sebroy mentioned this pull request Jan 10, 2020
Merged
11 tasks
@gllghr gllghr force-pushed the python3 branch 2 times, most recently from 622addb to 292d317 Compare January 15, 2020 05:30
@gllghr gllghr marked this pull request as ready for review January 15, 2020 05:37
@gllghr
Copy link
Contributor Author

gllghr commented Jan 15, 2020

Testing

sebroy
sebroy reviewed Jan 15, 2020
View reviewed changes
.github/scripts/flake8_stbtrace.sh

for prgm in $prgms; do
echo "Checking stbtrace program $prgm..."
./cmd/stbtrace.py $prgm --bcc >/tmp/$prgm.py ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clever

@gllghr gllghr merged commit 3f6c4b1 into delphix:master Jan 15, 2020
@gllghr gllghr deleted the python3 branch January 15, 2020 21:02
don-brady pushed a commit to don-brady/performance-diagnostics that referenced this pull request May 13, 2020
@gllghr
Switch to Python 3 [Backport of delphix#9 to 6.0.3.0]
5bce0be
don-brady pushed a commit to don-brady/performance-diagnostics that referenced this pull request May 13, 2020
@gllghr
Switch to Python 3 [Backport of delphix#9 to 6.0.3.0]
9115d83
don-brady pushed a commit to don-brady/performance-diagnostics that referenced this pull request May 19, 2020
@gllghr
Switch to Python 3 [Backport of delphix#9 to 6.0.3.0]
265c7ee
don-brady pushed a commit that referenced this pull request May 19, 2020
@gllghr
Switch to Python 3 [Backport of #9 to 6.0.3.0] (#43)
607e52f 
Co-authored-by: John Gallagher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebroy sebroy sebroy approved these changes

+1 more reviewer

@prashks prashks prashks left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gllghr @prashks @sebroy