Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 18, 2025

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jul 18, 2025
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@alamb alamb force-pushed the alamb/update_datafusion_49 branch from 5e5b545 to 01834d7 Compare July 18, 2025 20:04
@alamb alamb changed the title chore: Update to DataFusion 49.0.0 chore: update to DataFusion 49.0.0 Jul 18, 2025
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.43%. Comparing base (2846081) to head (b971f1e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/mod.rs 16.66% 5 Missing ⚠️
python/src/writer.rs 0.00% 2 Missing ⚠️
crates/core/src/operations/merge/barrier.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
+ Coverage   74.52%   75.43%   +0.90%     
==========================================
  Files         146      146              
  Lines       44919    44908      -11     
  Branches    44919    44908      -11     
==========================================
+ Hits        33477    33877     +400     
+ Misses       9248     9211      -37     
+ Partials     2194     1820     -374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alamb
Copy link
Contributor Author

alamb commented Jul 21, 2025

I also updated the version of rust used due to a failing CI

https://github.com/delta-io/delta-rs/actions/runs/16379330458/job/46335659927?pr=3603

error: rustc 1.82.0 is not supported by the following packages:
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
  [email protected] requires rustc 1.85.1
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.82.0

error: process didn't exit successfully: `/home/runner/.rustup/toolchains/1.82-x86_64-unknown-linux-gnu/bin/cargo test --tests --manifest-path /home/runner/work/delta-rs/delta-rs/Cargo.toml --target-dir /home/runner/work/delta-rs/delta-rs/target/llvm-cov-target --features integration_test,azure,datafusion,s3,gcs,glue,hdfs --workspace --exclude delta-inspect --exclude deltalake-hdfs --exclude deltalake-lakefs` (exit status: 101)

This came in as part of

I think it deserves a mention in the upgrade guide. I will do so

@ion-elgreco
Copy link
Collaborator

@alamb we pinned the aws sdk libraries actually so that we didn't have to bump our rustc version

@rtyler rtyler self-assigned this Jul 27, 2025
@rtyler rtyler force-pushed the alamb/update_datafusion_49 branch from 5117897 to b971f1e Compare July 27, 2025 16:10
@github-actions github-actions bot added the binding/python Issues for the Python package label Jul 27, 2025
@rtyler rtyler marked this pull request as ready for review July 27, 2025 16:24
@rtyler rtyler added this pull request to the merge queue Jul 27, 2025
Merged via the queue into delta-io:main with commit 3215340 Jul 27, 2025
27 of 29 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jul 28, 2025

🎉 thank you @rtyler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants