Skip to content

Add count field #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2019
Merged

Add count field #6

merged 3 commits into from
May 11, 2019

Conversation

demurgos
Copy link
Owner

This PR adds the non-V8 count field to FunctionCov. This field contains the total number of function calls. This allows to solve merging complex ranges or functions with mixed isBlockCoverage while preserving all the information.

It also updates the build tools: the latest versions remove the web stuff to focus on Node libraries.

Closes #2

@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #6 into master will decrease coverage by 8.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage      74%   65.32%   -8.68%     
==========================================
  Files           7        7              
  Lines         377      398      +21     
  Branches       43        0      -43     
==========================================
- Hits          279      260      -19     
- Misses         97      138      +41     
+ Partials        1        0       -1
Impacted Files Coverage Δ
ts/src/lib/merge.ts 87.2% <100%> (-12.8%) ⬇️
ts/src/lib/range-tree.ts 76.54% <0%> (-23.46%) ⬇️
ts/src/lib/compare.ts 91.66% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c232b...116fb08. Read the comment docs.

demurgos added 3 commits May 11, 2019 15:27
This commit adds the non-V8 `count` field to `FunctionCov`. This field contains the total number of function calls. This allows to solve merging complex ranges or functions with mixed `isBlockCoverage` while preserving all the information.
@demurgos demurgos merged commit 116fb08 into master May 11, 2019
@demurgos demurgos deleted the add-count-field branch September 25, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block and function level coverage are incompatible and should not be merged
2 participants