27689 Proposal for console command changes, removal of hardcoded values. #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this proposal is to allow console commands to be run on all environments hence:
In summary the rebuild is now split into two commands,
site:rebuild:fresh
for dev environments and new build production sites which:and
site:rebuild:prod
for existing prod deployments which:An alternative options seems to be to do away with
exec
bash commands and run everything as a new console command that is able to pick up the 'root' from the site.yml file, this might be better but might also take away a bit of the flexibility in quickly adding new steps to the chain...