chore(fs): document the deprecation of exists
and existsSync
#2730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exists
was deprecated because it causes a race condition when used before a file operation. However, it still has some legitimate uses cases, even withinstd
. The community has expressed more arguments here:This PR:
exists
andexistsSync
.exists
before a file operation and clearly explains the reasoning.exists
within the codebase.URL
support for the argument.A few legitimate use cases were also likely removed in #2546, as
Deno.lstat
is still used to check for the existence of files. It'd be a good idea to revisit these removals and consider re-adding theexists
, but only where appropriate.