Skip to content

feat(fs/unstable): add chown and chownSync #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

jbronder
Copy link
Contributor

@jbronder jbronder commented Apr 6, 2025

This PR adds chown and chownSync APIs to @std/fs package which are intended to mirror the Deno.chown and Deno.chownSync functions.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner April 6, 2025 05:05
@github-actions github-actions bot added the fs label Apr 6, 2025
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 95.03%. Comparing base (9d765df) to head (d8173b4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_chown.ts 60.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6552      +/-   ##
==========================================
- Coverage   95.06%   95.03%   -0.03%     
==========================================
  Files         576      577       +1     
  Lines       43370    43405      +35     
  Branches     6472     6475       +3     
==========================================
+ Hits        41231    41252      +21     
- Misses       2098     2112      +14     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

});

Deno.test({
name: "chown() handles `null` id arguments",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test case 👍

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 1853cde into denoland:main Apr 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants