Autocomplete attribute to allow for synonyms of on/off

[WilcoFiers]

This should't be failed:

<input autocomplete="none" />

Unfortunately, the only way I can think that we allow this is to create a list of synonyms that someone might mistakenly be using, instead of using "on" or "off" which are actually allowed. So things like "none", "false", "true", "disabled", "enabled", "undefined", "null", etc. They'll need to be in a check option, so that this can be configured.

I don't think we should even bother to report them as incomplete. Passing the rule is fine in this scenario.

[maruthimohan]

@WilcoFiers can I work on this issue? Also, could you give me a little more context on this issue?

[WilcoFiers]

@maruthimohan Sure, go for it. I suspect the only thing we'll need to do is to update the autocomplete-valid.json check; add in an "options" property with { "stateTerms": ["list", "of", "extra", "allowed", "words"] }. And then add a few integration tests (test/integration/rules/autocomplete-valid/) that show that when these terms are used, axe-core passes these rules.

[padmavemulapati]

Valdiated with the latest axe-core, develop branch code base,
not seeing failure on auto-complete-valid rule, when "none", "false", "true", "disabled", "enabled", "undefined", "null"

was able to see failure earlier in this

[ljharb]

For posterity: this broke eslint-plugin-jsx-a11y's tests; specifically, we were asserting that <input type={isEmail ? "email" : "text"} autocomplete="none" /> is invalid, and v4.4 made it valid.

I don't think this is a breaking change, exactly, because it turned an error into a non-error, but it's worth keeping in mind for the future.