Use custom shared libraries from ffmpeg-build-scripts fork instead of homebrew

.github/workflows/prebuild.yml

@@ -21,34 +21,43 @@ jobs:
         with:
           node-version: 14.8.0
 
+      - name: npm install
+        run: npm install
+        env:
+          PREBUILD: true
+
       - name: install Linux dependencies
         run: |
           sudo add-apt-repository ppa:jonathonf/ffmpeg-4
           sudo apt-get update
           sudo apt-get install libavcodec-dev libavformat-dev libavdevice-dev libavfilter-dev libavutil-dev libpostproc-dev libswresample-dev libswscale-dev
         if: ${{ runner.os == 'Linux' }}
 
-      - name: install Mac dependencies
-        run: brew install nasm pkg-config ffmpeg
+      - name: install Mac build dependencies (brew)
+        run: brew install nasm pkg-config
+        if: ${{ runner.os == 'macOS'}}
+
+      - name: install Mac dependencies (shared release)
+        run: node ./install_ffmpeg.js
         if: ${{ runner.os == 'macOS'}}
 
       - name: install Windows dependencies
         run: node ./install_ffmpeg.js
         if: ${{ runner.os == 'Windows'}}
 
       - name: prebuild for macOS (x64)
-        run: npx prebuild --runtime napi --arch x64 --prepack copy_mac_libs.js --include-regex '\.(node|dylib)$' --upload ${{ secrets.GITHUB_TOKEN }}
+        run: npx prebuild --runtime napi --arch x64 --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
         if: ${{ runner.os == 'macOS'}}
 
-      - name: prebuild for macOS (arm64)
-        run: npx prebuild --runtime napi --arch arm64 --prepack copy_mac_libs.js --include-regex '\.(node|dylib)$' --upload ${{ secrets.GITHUB_TOKEN }}
-        if: ${{ runner.os == 'macOS'}}
+#      - name: prebuild for macOS (arm64)
+#        run: npx prebuild --runtime napi --arch arm64 --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
+#        if: ${{ runner.os == 'macOS'}}
 
       - name: prebuild for Windows
-        # I can't get the pipe character to work on windows, so to include both .node and .dll files I have this weird regexp
-        run: npx prebuild --runtime napi --include-regex '\.[nd][ol][dl]e?$' --upload ${{ secrets.GITHUB_TOKEN }}
+        run: npx prebuild --runtime napi --include-regex '"(\.node|\.dll|ffmpeg\.exe|ffprobe\.exe)$"' --upload ${{ secrets.GITHUB_TOKEN }}
+        shell: bash
         if: ${{ runner.os == 'Windows'}}
 
       - name: prebuild for Linux
-        run: npx prebuild --runtime napi --upload ${{ secrets.GITHUB_TOKEN }}
+        run: npx prebuild --runtime napi --include-regex '(\.node|\.dylib|ffmpeg|ffprobe)$' --upload ${{ secrets.GITHUB_TOKEN }}
         if: ${{ runner.os == 'Linux'}}

.gitignore

@@ -74,3 +74,5 @@ ffmpeg/
 # Editors and IDE's
 *.swp
 .vscode/
+
+.DS_Store

.node-version

@@ -0,0 +1 @@
+12.18.3

binding.gyp

@@ -12,7 +12,7 @@
        "NAPI_VERSION=<(napi_build_version)"
     ],
     "conditions": [
-      ['OS!="win"', {
+      ['OS=="linux"', {
         "defines": [
           "__STDC_CONSTANT_MACROS"
         ],
@@ -35,8 +35,64 @@
             "-lswresample",
             "-lswscale"
           ]
-        }
+        },
+        "copies": [
+            {
+              "destination": "build/Release/",
+              "files": [
+                "node_modules/ffmpeg-ffprobe-static/ffmpeg",
+                "node_modules/ffmpeg-ffprobe-static/ffprobe",
+              ]
+            }
+          ]
       }],
+      ["OS=='mac'", {
+        "variables": {
+           "ffmpeg_version": "1.21.rc5"
+        },
+        "defines": [
+          "__STDC_CONSTANT_MACROS"
+        ],
+        "cflags_cc!": [
+          "-fno-rtti",
+          "-fno-exceptions"
+        ],
+        "cflags_cc": [
+          "-std=c++11",
+          "-fexceptions"
+        ],
+        "include_dirs": [
+          "<(module_root_dir)/ffmpeg/ffmpeg-ffprobe-shared-darwin-x86_64.<(ffmpeg_version)/include/"
+        ],
+        "link_settings": {
+          "library_dirs": [
+            "<(module_root_dir)/ffmpeg/ffmpeg-ffprobe-shared-darwin-x86_64.<(ffmpeg_version)/"
+          ],
+          "libraries": [
+            "-Wl,-rpath,@loader_path",
+            "-lavcodec",
+            "-lavdevice",
+            "-lavfilter",
+            "-lavformat",
+            "-lavutil",
+            "-lpostproc",
+            "-lswresample",
+            "-lswscale"
+          ],
+        },
+        'xcode_settings': {
+          'MACOSX_DEPLOYMENT_TARGET': '10.11',
+        },
+        "copies": [
+            {
+              "destination": "build/Release/",
+              "files": [
+                "<!@(node -p \"require('fs').readdirSync('ffmpeg/ffmpeg-ffprobe-shared-darwin-x86_64.<(ffmpeg_version)').map(f => 'ffmpeg/ffmpeg-ffprobe-shared-darwin-x86_64.<(ffmpeg_version)/' + f).join(' ')\")"
+              ]
+            }
+          ]
+      }
+      ],
       ['OS=="win"', {
         "configurations": {
           "Release": {
@@ -72,6 +128,8 @@
                 "ffmpeg/ffmpeg-4.3-win64-shared/bin/postproc-55.dll",
                 "ffmpeg/ffmpeg-4.3-win64-shared/bin/swresample-3.dll",
                 "ffmpeg/ffmpeg-4.3-win64-shared/bin/swscale-5.dll"
+                "node_modules/ffmpeg-ffprobe-static/ffmpeg.exe",
+                "node_modules/ffmpeg-ffprobe-static/ffprobe.exe",
               ]
             }
           ]

index.d.ts

@@ -11,6 +11,7 @@ export * from "./types/Encoder"
 export * from "./types/Muxer"
 export * from "./types/Beamstreams"
 export * from "./types/HWContext"
+export * from "./types/paths"
 
 export const AV_NOPTS_VALUE: number
 

index.js

@@ -35,6 +35,12 @@ https://github.com/Streampunk/beamcoder/blob/master/LICENSE`;
 console.log(splash);
 console.log('Using FFmpeg version', beamcoder.avVersionInfo());
 
+if (Object.values(beamcoder.configurations()).some(value => value.includes('--enable-small'))) {
+  console.error('beamcoder will crash because ffmpeg is compiled' +
+    ' with --enable-small (because, for example, codec->long_name is ' +
+    'NULL and beamcoder expects it to be defined)');
+}
+
 beamcoder.demuxerStream = beamstreams.demuxerStream;
 beamcoder.muxerStream = beamstreams.muxerStream;
 

install.js

@@ -0,0 +1,5 @@
+const {execSync} = require('child_process');
+
+if (!process.env.PREBUILD) {
+  execSync('npx prebuild-install --runtime napi');
+}

install_ffmpeg.js

@@ -175,35 +175,34 @@ sudo apt-get install libavcodec-dev libavformat-dev libavdevice-dev libavfilter-
 }
 
 async function darwin() {
-  console.log('Checking for FFmpeg dependencies via HomeBrew.');
-  let output;
-  let returnMessage;
-
-  try {
-    output = await exec('brew list ffmpeg');
-    returnMessage = 'FFmpeg already present via Homebrew.';
-  } catch (err) {
-    if (err.stderr !== 'Error: No such keg: /usr/local/Cellar/ffmpeg\n') {
-      console.error(err);
-      console.log('Either Homebrew is not installed or something else is wrong.\nExiting');
-      process.exit(1);
-    }
-
-    console.log('FFmpeg not installed. Attempting to install via Homebrew.');
-    try {
-      output = await exec('brew install nasm pkg-config texi2html ffmpeg');
-      returnMessage = 'FFmpeg installed via Homebrew.';
-    } catch (err) {
-      console.log('Failed to install ffmpeg:\n');
-      console.error(err);
-      process.exit(1);
-    }
-  }
+  console.log('Checking/downloading ffmpeg shared libraries');
+
+  await mkdir('ffmpeg').catch(e => {
+    if (e.code === 'EEXIST') return;
+    else throw e;
+  });
+
+  const version = '1.21.rc5';
+  const ffmpegFilename = `ffmpeg-ffprobe-shared-darwin-x86_64.${version}`;
 
-  console.log(output.stdout);
-  console.log(returnMessage);
+  await access(`ffmpeg/${ffmpegFilename}`, fs.constants.R_OK).catch(async () => {
+    const ws = fs.createWriteStream(`ffmpeg/${ffmpegFilename}.zip`);
+    await get(
+      ws,
+      `https://github.com/descriptinc/ffmpeg-build-script/releases/download/v${version}/${ffmpegFilename}.zip`,
+      `${ffmpegFilename}.zip`
+    ).catch(async (err) => {
+      if (err.name === 'RedirectError') {
+        const redirectURL = err.message;
+        await get(ws, redirectURL, `${ffmpegFilename}.zip`);
+      } else {
+        console.error(err);
+        throw err;
+      }
+    });
 
-  return 0;
+    await exec(`unzip ffmpeg/${ffmpegFilename}.zip -d ffmpeg/${ffmpegFilename}/`);
+  });
 }
 
 switch (os.platform()) {