This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Add CentOS7 with MariaDB support #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
reviewed
Apr 21, 2017
| include_vars: "{{ item }}" | ||
| with_first_found: | ||
| - "{{ ansible_os_family }}-{{ ansible_distribution_major_version }}.yml" | ||
| - "{{ ansible_os_family }}.yml" |
There was a problem hiding this comment.
Could you please add ansible_distribution here? Not that its needed right now, but I'd like to have it standardized in the hardening roles.
- name: Set OS dependent variables
include_vars: "{{ item }}"
with_first_found:
- "{{ ansible_distribution }}_{{ ansible_distribution_major_version }}.yml"
- "{{ ansible_distribution }}.yml"
- "{{ ansible_os_family }}_{{ ansible_distribution_major_version }}.yml"
- "{{ ansible_os_family }}.yml"
|
Except for this one minor thing I added, this PR is good to merge. Thanks! |
rndmh3ro
approved these changes
Apr 21, 2017
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration for RedHat 7-based servers that specifies "mariadb" as the value for mysql_daemon.
There is also Test Kitchen test for CentOS 7.2, which is passes, though I would point out that other tests (for Ubuntu and CentOS 6.x) are failing even before this PR -- at least on my setup.
This addresses issue #23.