Skip to content

Update collection-index.yml #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2025
Merged

Update collection-index.yml #518

merged 2 commits into from
Feb 24, 2025

Conversation

sebst
Copy link
Contributor

@sebst sebst commented Jan 25, 2025 •
edited
Loading

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Please replace this line with a description of your PR.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@sebst sebst requested a review from a team as a code owner January 25, 2025 17:32
@Kaniska244
Copy link

Thanks for the PR!
Change approved. This can be merged.

eljog
eljog previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR
Please resolve conflicts

@sebst
Copy link
Contributor Author

sebst commented Feb 24, 2025

Thanks for the PR Please resolve conflicts

Thanks for the review. Conflicts resolved.

@eljog eljog merged commit f7321d6 into devcontainers:gh-pages Feb 24, 2025
1 check passed
Badboyboom
Badboyboom reviewed Feb 25, 2025
View reviewed changes
Copy link

@Badboyboom Badboyboom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier of the Feature. Must be unique in the context of the repository where the Feature exists and must match the name of the directory where the devcontainer-feature.json resides.

Badboyboom
Badboyboom reviewed Feb 25, 2025
View reviewed changes
Copy link

@Badboyboom Badboyboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_data/collection-index.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badboyboom Badboyboom Badboyboom left review comments

@eljog eljog eljog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebst @Kaniska244 @eljog @Badboyboom