Skip to content

Update collection-index.yml #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

RouL
Copy link
Contributor

@RouL RouL commented Feb 14, 2025

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

None

Description

Added "devcontainer features by RouL" to the collection index.

Collection checklist

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@RouL RouL requested a review from a team as a code owner February 14, 2025 22:05
@Kaniska244
Copy link

Hi @RouL ,

Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same.
The supporting tools do help convert the case, however, its better to sync as much as possible.

With Regards,
Kaniska

RouL added a commit to RouL/devcontainer-features that referenced this pull request Feb 19, 2025
According to ORAS spec ice references should be lowercase (devcontainers/devcontainers.github.io#523)
@RouL
Copy link
Contributor Author

RouL commented Feb 19, 2025

Hi @Kaniska244 ,

I'm sorry, I wasn't aware of that. I fixed everything in the repo and also changed the PR accordingly.

Regards,
Markus

@Kaniska244
Copy link

Change is approved. This can be merged.

@RouL
Copy link
Contributor Author

RouL commented Feb 20, 2025

Hi @samruddhikhandale,

I usually don't ping people to "push" something, but I hope you don't mind. Can you have a look at this please? :)

Regards,
Markus

ddoyle2017
ddoyle2017 previously approved these changes Feb 24, 2025
Copy link

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please resolve the merge conflicts and we can get this added in 🤙

@RouL
Copy link
Contributor Author

RouL commented Feb 24, 2025

@ddoyle2017 Thanks, I did a quick merge of the conflicting changes, I hope that's ok. :)

@eljog
Copy link
Member

eljog commented Feb 24, 2025

@RouL another merge caused a new conflict. If you can give it another stab at solving it now, I can help to merge it before another one gets in the way 🤞

@RouL
Copy link
Contributor Author

RouL commented Feb 24, 2025

@eljog Thank for the quick message. Not my lucky day I guess. I did move mine back to the bottom while merging, that should help I hope. :)

Copy link

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddoyle2017 ddoyle2017 merged commit 25f3005 into devcontainers:gh-pages Feb 24, 2025
1 check passed
@ddoyle2017
Copy link

ddoyle2017 commented Feb 24, 2025

@eljog Thank for the quick message. Not my lucky day I guess. I did move mine back to the bottom while merging, that should help I hope. :)

You're all set! @RouL

@RouL RouL deleted the add-roul-feature-repo branch February 24, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants