-
Notifications
You must be signed in to change notification settings - Fork 298
Update collection-index.yml #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update collection-index.yml #523
Conversation
Hi @RouL , Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same. With Regards, |
According to ORAS spec ice references should be lowercase (devcontainers/devcontainers.github.io#523)
Hi @Kaniska244 , I'm sorry, I wasn't aware of that. I fixed everything in the repo and also changed the PR accordingly. Regards, |
Change is approved. This can be merged. |
I usually don't ping people to "push" something, but I hope you don't mind. Can you have a look at this please? :) Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please resolve the merge conflicts and we can get this added in 🤙
@ddoyle2017 Thanks, I did a quick merge of the conflicting changes, I hope that's ok. :) |
@RouL another merge caused a new conflict. If you can give it another stab at solving it now, I can help to merge it before another one gets in the way 🤞 |
@eljog Thank for the quick message. Not my lucky day I guess. I did move mine back to the bottom while merging, that should help I hope. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
What type of PR is this?
Related Issues
None
Description
Added "devcontainer features by RouL" to the collection index.
Collection checklist