Skip to content

Update links and headers #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Conversation

bamurtaugh
Copy link
Member

@bamurtaugh bamurtaugh commented Jun 1, 2022

cc @Chuxel

@bamurtaugh bamurtaugh self-assigned this Jun 1, 2022
@Chuxel
Copy link
Member

Chuxel commented Jun 2, 2022

Made some additional comments on devcontainers/spec#39

For the schema - do we want people doing a PR to VS Code or the spec repo once we do devcontainers/spec#14 ? (and should we do that at this point is another related question)

//cc @chrmarti on the schema

@bamurtaugh bamurtaugh requested a review from chrmarti June 2, 2022 18:05
@bamurtaugh
Copy link
Member Author

Thanks @Chuxel! I'll keep an eye on that PR and add further updates here.

For the schema - do we want people doing a PR to VS Code or the spec repo once we do devcontainers/spec#14 ? (and should we do that at this point is another related question)

Ah good point. I think a PR to the spec repo would be best as it's tool agnostic. In which case, moving the schema now makes sense to me, if @chrmarti agrees. This could at least account for part of devcontainers/spec#14, if we needed to wait or discuss a bit more the schema store part.

Do we need to advise users to update anything in VS Code to get sufficient IntelliSense? Based on @chrmarti's comment: One disadvantage might be that other editors will not offer IntelliSense for the VS Code and Codespaces parts, but that might be fine, it sounds like this would be something for other editors to account for, but not something we'd need to provide updates for in VS Code.

@bamurtaugh
Copy link
Member Author

bamurtaugh commented Jun 6, 2022

Added all the latest from @edgonmsft's PR devcontainers/spec#39.

Regarding the contributions.md update to describe updating the schema: I propose we remove that info until we move the schema to the spec repo (part of devcontainers/spec#14), otherwise it feels less VS Code agnostic to direct people to the VS Code repo. I've removed that content now, and I'll proceed with merging this PR.

@bamurtaugh bamurtaugh merged commit 41ead47 into gh-pages Jun 6, 2022
@bamurtaugh bamurtaugh deleted the bamurtaugh/links-headers branch June 6, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants