-
Notifications
You must be signed in to change notification settings - Fork 470
Closed
Description
Rust 1.87.0 has finally removed the long deprecated RLS (see also Previous Components), but the rust
feature unfortunately installs that component unconditionally:
Line 206 in 4f8a62a
rustup component add rls rust-analysis rust-src rustfmt clippy 2>&1 |
This results in a build error:
#17 21.24 Installing common Rust dependencies...
#17 21.39 error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain component 'rls' for target 'x86_64-unknown-linux-gnu'; did you mean 'rustc'?
#17 21.40 ERROR: Feature "Rust" (ghcr.io/devcontainers/features/rust) failed to install! Look at the documentation at ********/devcontainers/features/tree/main/src/rust for help troubleshooting this error.
#17 ERROR: process "/bin/sh -c cp -ar /tmp/build-features-src/rust_2 /tmp/dev-container-features && chmod -R 0755 /tmp/dev-container-features/rust_2 && cd /tmp/dev-container-features/rust_2 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh && rm -rf /tmp/dev-container-features/rust_2" did not complete successfully: exit code: 1
and "This codespace is currently running in recovery mode due to a container error."
Can we please drop rls
and rust-analysis
from the rustup component add
invocation?
NeoScript, KarstenB, Carlton-Perkins, blixt and saikatdas0790
Metadata
Metadata
Assignees
Labels
No labels
Activity
NeoScript commentedon May 15, 2025
I can second this. I was about to post an issue myself when I first saw this
This is my error log when trying to add the devcontainer feature to a python based devcontainer
I would recommend adding
rust-analyzer
as a replacement forrls
. Additionally, perhaps we drop support for versions of rust older than 1.64 to prevent issues sincerust-analyzer
was released during 1.64Sources:
https://doc.rust-lang.org/stable/releases.html#misc-6
rust-lang/rust#98640
liskin commentedon May 16, 2025
I don't think this is necessary. VSCode downloads and uses its own copy of rust-analyzer. Not sure if enough people use emacs/neovim in a devcontainer/Codespaces to justify installing it using rustup as well.
(I mean, not that I really care… but if I were to add it I'd like to understand why I'm doing it.)
KarstenB commentedon May 16, 2025
Just ran into this as well. I also think that most tools either install it themselves or don't use it. Complete removal is fine for me. Another option would be to add a
components
option and allow to override the components that are to be installed.fix(rust): remove rls and rust-analysis for Rust 1.87+ compatibility (#…