-
Notifications
You must be signed in to change notification settings - Fork 309
Add devcontainer.json reference #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great to see this here 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's probably some tweaking we should make to make the reference a bit less VS Code specific. Some thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple other thoughts
Hey team, do we think this is ready to merge? And we can always continue revising in the future? |
@bamurtaugh Yes with one possible caveat... @chrmarti Is the I'm kind of thinking we should update this reference to call out what the |
I have only added the |
I can hold off on merging until |
Closing in favor of #33. |
Adding the devcontainer.json reference content so that it is available in this repo. Using a
docs
folder to contain this and any potential future docs we'd like to include.cc @chrmarti @joshspicer @edgonmsft