Skip to content

Add devcontainer.json reference #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

Conversation

bamurtaugh
Copy link
Member

Adding the devcontainer.json reference content so that it is available in this repo. Using a docs folder to contain this and any potential future docs we'd like to include.

cc @chrmarti @joshspicer @edgonmsft

@bamurtaugh bamurtaugh self-assigned this Feb 15, 2022
@joshspicer
Copy link
Member

Great to see this here 🎉

Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's probably some tweaking we should make to make the reference a bit less VS Code specific. Some thoughts.

@Chuxel Chuxel closed this Feb 15, 2022
@Chuxel Chuxel reopened this Feb 15, 2022
@bamurtaugh
Copy link
Member Author

bamurtaugh commented Feb 23, 2022

@Chuxel @chrmarti I updated the folder structure to:

/docs
-- /images
-- /specs
---- devcontainerjson-reference.md
---- supporting-tools.md
---- /schemas

Let me know if that seems reasonable to you.

Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple other thoughts

@bamurtaugh
Copy link
Member Author

Hey team, do we think this is ready to merge? And we can always continue revising in the future?

@Chuxel
Copy link
Member

Chuxel commented Apr 1, 2022

@bamurtaugh Yes with one possible caveat...

@chrmarti Is the customizations.vscode update in the version of everything that just shipped?

I'm kind of thinking we should update this reference to call out what the customizations property is for under the "tool specific properties" section in the main reference, and then update the tool specific properties to reflect this change.

@chrmarti
Copy link
Contributor

chrmarti commented Apr 4, 2022

I have only added the customizations wildcard for now. customizations.vscode is not there yet.

@bamurtaugh
Copy link
Member Author

I can hold off on merging until customizations.vscode is in, and then update this PR accordingly.

@bamurtaugh
Copy link
Member Author

Closing in favor of #33.

@bamurtaugh bamurtaugh closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants