-
Notifications
You must be signed in to change notification settings - Fork 309
Update README.md #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts on second read.
README.md
Outdated
# Development Containers | ||
|
||
This repository is for issues to shape the direction of development containers and the dev container CLI. | ||
This repository is for issues to shape the direction of development containers and the development container CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should get more specific and say this is specifically for the dev container spec.
We've talked about the CLI potentially being in a different repo. @charmarti - Assuming that's the way it goes, would we keep issues specific to the CLI implementation there? (I assume so).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to This repository is for the Development Container Specification.
- does that read better?
We've talked about the CLI potentially being in a different repo. @charmarti - Assuming that's the way it goes, would we keep issues specific to the CLI implementation there?
Do we think seeking issues in another location could be confusing? As this open spec concept will be new to folks, wondering if there's anything we should consider, i.e. a list of which repos users should file issues in for what?
cc @chrmarti
Generally LGTM! On question I have is whether we want to reference the CLI as "coming soon" given its not available yet. The alternative would be to not mention it right now. |
Good call out @Chuxel! Updated to:
Does that sound reasonable? |
Yep! |
Thanks for the reviews! Merging now. |
Updating based on feedback.
cc @joshspicer @edgonmsft @sinedied