Skip to content

Update README.md #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Update README.md #17

merged 4 commits into from
Mar 18, 2022

Conversation

bamurtaugh
Copy link
Member

Updating based on feedback.

cc @joshspicer @edgonmsft @sinedied

@bamurtaugh bamurtaugh requested review from Chuxel and chrmarti March 11, 2022 20:18
@bamurtaugh bamurtaugh self-assigned this Mar 11, 2022
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts on second read.

README.md Outdated
Comment on lines 1 to 3
# Development Containers

This repository is for issues to shape the direction of development containers and the dev container CLI.
This repository is for issues to shape the direction of development containers and the development container CLI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should get more specific and say this is specifically for the dev container spec.

We've talked about the CLI potentially being in a different repo. @charmarti - Assuming that's the way it goes, would we keep issues specific to the CLI implementation there? (I assume so).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to This repository is for the Development Container Specification. - does that read better?

We've talked about the CLI potentially being in a different repo. @charmarti - Assuming that's the way it goes, would we keep issues specific to the CLI implementation there?

Do we think seeking issues in another location could be confusing? As this open spec concept will be new to folks, wondering if there's anything we should consider, i.e. a list of which repos users should file issues in for what?

cc @chrmarti

@bamurtaugh
Copy link
Member Author

@Chuxel @chrmarti Does the current state of this PR look good to merge?

@Chuxel
Copy link
Member

Chuxel commented Mar 17, 2022

Generally LGTM! On question I have is whether we want to reference the CLI as "coming soon" given its not available yet. The alternative would be to not mention it right now.

@bamurtaugh
Copy link
Member Author

Good call out @Chuxel! Updated to:

You will be able to use the upcoming open-source CLI reference implementation either directly...

Does that sound reasonable?

@Chuxel
Copy link
Member

Chuxel commented Mar 18, 2022

Yep!

@bamurtaugh
Copy link
Member Author

Thanks for the reviews! Merging now.

@bamurtaugh bamurtaugh merged commit 81cd575 into main Mar 18, 2022
@bamurtaugh bamurtaugh deleted the bamurtaugh-readme branch March 18, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants