Skip to content

feat: Deprecate custom NotFoundError in favor of built-in FileNotFoundError #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

feat: Deprecate custom NotFoundError in favor of built-in FileNotFoundError #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68f52e0
feat: Deprecate custom NotFoundError in favor of built-in FileNotFoun…
kylebarron Jun 23, 2025
60146b7
Note that BaseError is not universally used.
kylebarron Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion obstore/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ build-backend = "maturin"
[project]
name = "obstore"
requires-python = ">=3.9"
dependencies = ["typing-extensions; python_version < '3.12'"]
dependencies = ["typing-extensions; python_version < '3.13'"]
classifiers = [
"Development Status :: 4 - Beta",
"Framework :: AsyncIO",
Expand Down
14 changes: 13 additions & 1 deletion obstore/python/obstore/exceptions/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,24 @@
# pylance isn't able to find that. So this is an exceptions module with only
# `__init__.pyi` to work around pylance's bug.

import sys

if sys.version_info >= (3, 13):
from warnings import deprecated
else:
from typing_extensions import deprecated

class BaseError(Exception):
"""The base exception class."""
"""The base exception class.

!!! note
Some operations also raise a built-in `ValueError` or `FileNotFoundError`.
"""

class GenericError(BaseError):
"""A fallback error type when no variant matches."""

@deprecated("builtins.FileNotFoundError is emitted instead.")
class NotFoundError(BaseError):
"""Error when the object is not found at given location."""

Expand Down
Loading