-
Notifications
You must be signed in to change notification settings - Fork 19
Feat/bulk action component #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NoOne7135
wants to merge
4
commits into
next
Choose a base branch
from
feat/bulkActionComponent
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e850dee
chore: bulk action component progress
NoOne7135 c83ee3b
feat: add CallActionWrapper component and integrate with action menus
NoOne7135 e65f705
fix: enhance CallActionWrapper to accept extra props and update Three…
NoOne7135 a5defaf
Update 02-TwoFactorsAuth.md
ivictbor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<template> | ||
<div @click="onClick"> | ||
<slot /> | ||
</div> | ||
</template> | ||
|
||
<script setup lang="ts"> | ||
const props = defineProps<{ disabled?: boolean, extra?: any }>(); | ||
const emit = defineEmits<{ (e: 'callAction', extra?: any ): void }>(); | ||
|
||
function onClick() { | ||
if (props.disabled) return; | ||
emit('callAction', props.extra); | ||
} | ||
</script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -185,14 +185,37 @@ | |||||
/> | ||||||
</template> | ||||||
|
||||||
<template v-if="resource.options?.actions"> | ||||||
<Tooltip v-for="action in resource.options.actions.filter(a => a.showIn?.list)" :key="action.id"> | ||||||
<button | ||||||
@click="startCustomAction(action.id, row)" | ||||||
<template v-if="resource.options?.actions"> | ||||||
<Tooltip | ||||||
v-for="action in resource.options.actions.filter(a => a.showIn?.list)" | ||||||
:key="action.id" | ||||||
> | ||||||
<CallActionWrapper | ||||||
:disabled="rowActionLoadingStates?.[action.id]" | ||||||
@callAction="startCustomAction(action.id, row)" | ||||||
> | ||||||
<component v-if="action.icon" :is="getIcon(action.icon)" class="w-5 h-5 mr-2 text-lightPrimary dark:text-darkPrimary"></component> | ||||||
</button> | ||||||
<template v-slot:tooltip> | ||||||
<component | ||||||
:is="action.customComponent ? getCustomComponent(action.customComponent) : 'span'" | ||||||
:meta="action.customComponent?.meta" | ||||||
:row="row" | ||||||
:resource="resource" | ||||||
:adminUser="adminUser" | ||||||
> | ||||||
<button | ||||||
type="button" | ||||||
:disabled="rowActionLoadingStates?.[action.id]" | ||||||
@click.stop.prevent="startCustomAction(action.id, row)" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The click handler uses both .stop and .prevent modifiers which might be overly restrictive. Consider if both are necessary or if this could interfere with expected event behavior.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
> | ||||||
<component | ||||||
v-if="action.icon" | ||||||
:is="getIcon(action.icon)" | ||||||
class="w-5 h-5 mr-2 text-lightPrimary dark:text-darkPrimary" | ||||||
/> | ||||||
</button> | ||||||
</component> | ||||||
</CallActionWrapper> | ||||||
|
||||||
<template #tooltip> | ||||||
{{ action.name }} | ||||||
</template> | ||||||
</Tooltip> | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<span> TEST CUSTOM COMPONENT </span> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The click handler uses both .stop and .prevent modifiers which might be overly restrictive. Consider if both are necessary or if this could interfere with expected event behavior.
Copilot uses AI. Check for mistakes.