Fix bridge conflict detection #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge conflict detection was broken since it would check bridge ranges that use the
nullIPAM driver (e.g. this very plugin!).nullspecifies a subnet of0.0.0.0/0, which would obviously pass any IP range check. Any network usingnullor a/0mask will be skipped, and otherdocker-net-dhcpnetworks' bridges will be compared in addition.If the user wants to re-use the same bridge across multiple networks (not really recommended) or for some reason the conflict detection is still wrong, the new
ignore_conflictsoption can be used.Fixes #18.